Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Make page exports stripper use Atom instead of String #75595

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 3, 2025

What?

Use swc_atoms::Atom instead of String in next-swc.

Why?

Atom does not allocate if another instance has the same value, meaning that clone() is a single atomic operation. But String allocates regardless of any other occurrence.

Closes PACK-3890

@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-7 branch from 3061e10 to cb35348 Compare February 3, 2025 11:40
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-8 branch 2 times, most recently from 28aa407 to 29681fc Compare February 3, 2025 14:52
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-7 branch 2 times, most recently from 2fce0f4 to a390443 Compare February 3, 2025 21:34
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-8 branch from 29681fc to 8cc556d Compare February 3, 2025 21:34
@ijjk
Copy link
Member

ijjk commented Feb 3, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
buildDuration 19.5s 18.1s N/A
buildDurationCached 16.9s 14.4s N/A
nodeModulesSize 392 MB 392 MB
nextStartRea..uration (ms) 465ms 457ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.5 kB 34.5 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
index.html gzip 525 B 524 B N/A
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 520 B 520 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
edge-ssr.js gzip 130 kB 130 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
middleware-b..fest.js gzip 676 B 671 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
app-page-exp...dev.js gzip 385 kB 385 kB
app-page-exp..prod.js gzip 132 kB 132 kB
app-page-tur..prod.js gzip 145 kB 145 kB
app-page-tur..prod.js gzip 141 kB 141 kB
app-page.run...dev.js gzip 372 kB 372 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 39.3 kB 39.3 kB
app-route-ex..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.6 kB 25.6 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 40.8 kB 40.8 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
dist_client_...dev.js gzip 356 B 356 B
dist_client_...dev.js gzip 349 B 349 B
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.8 kB 11.8 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 31.5 kB 31.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 60.5 kB 60.5 kB
Overall change 1.65 MB 1.65 MB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/next-swc-alloc-8 Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +1.59 kB
index.pack gzip 75.9 kB 74.4 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +1.59 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: f7d21b6

@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-7 branch from a390443 to 8edd757 Compare February 3, 2025 22:34
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-8 branch 2 times, most recently from f79521b to 9aca07e Compare February 4, 2025 11:23
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-7 branch 2 times, most recently from 79c44a2 to ec7e899 Compare February 4, 2025 14:05
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-8 branch from 9aca07e to 8bbfdc3 Compare February 4, 2025 14:05
@kdy1 kdy1 changed the base branch from kdy1/next-swc-alloc-7 to graphite-base/75595 February 4, 2025 23:32
@kdy1 kdy1 force-pushed the graphite-base/75595 branch from ec7e899 to 49b93c6 Compare February 4, 2025 23:32
@kdy1 kdy1 force-pushed the kdy1/next-swc-alloc-8 branch from 8bbfdc3 to f7d21b6 Compare February 4, 2025 23:32
@kdy1 kdy1 changed the base branch from graphite-base/75595 to canary February 4, 2025 23:33
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

  • Feb 5, 8:33 AM GMT+9: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@kdy1 kdy1 enabled auto-merge (squash) February 4, 2025 23:33
@ijjk
Copy link
Member

ijjk commented Feb 4, 2025

Failing test suites

Commit: f7d21b6

pnpm test-dev-turbo test/development/acceptance/error-recovery.test.ts (turbopack)

  • ReactRefreshLogBox turbo > render error not shown right after syntax error
Expand output

● ReactRefreshLogBox turbo › render error not shown right after syntax error

expect(received).toInclude(expected)

Expected string to include:
  "render() {"
Received:
  "./index.js:5:5
Parsing ecmascript source code failed
  3 | class ClassDefault extends React.Component {
  4 |   render()
> 5 |     return <h1>Default Export</h1>;
    |     ^^^^^^
  6 |   }
  7 | }
  8 |·
Expected '{', got 'return'"

  302 |     await session.assertHasRedbox()
  303 |
> 304 |     await expect(session.getRedboxSource()).resolves.toInclude('render() {')
      |                                                      ^
  305 |
  306 |     expect(await session.getRedboxSource()).toInclude(
  307 |       "throw new Error('nooo');"

  at Object.toInclude (../node_modules/.pnpm/expect@29.7.0/node_modules/expect/build/index.js:174:22)
  at Object.toInclude (development/acceptance/error-recovery.test.ts:304:54)

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 merged commit 05b9184 into canary Feb 5, 2025
245 of 247 checks passed
@kdy1 kdy1 deleted the kdy1/next-swc-alloc-8 branch February 5, 2025 00:28
@kdy1 kdy1 self-assigned this Feb 5, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants